Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-10322

[ContentSearchHelper] the #getAttributeValue should not take the modelItem as parameter

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Major Major
    • 4.9.0
    • 4.3.0
    • None
    • None
    • 1 - Middle term
    • 2 - Normal

      The ContentSearchHelper#getAttributeValue receives a content, a data path and a model item. But the model item could be computed via a content#getDefinition(dataPath) call

      This could lead to less errors because the given model item could be wrong.

      Example with Jira CMS-10299: The given model item was the title attribute definition staticly computed by ContentTypesHelper#getTitleAttributeDefinition, with a String type. But the content had a multilingual title (this was an error fixed in the CMS-10299). This led to an error in value transforming

          [CMS-10322] [ContentSearchHelper] the #getAttributeValue should not take the modelItem as parameter

          Laurence Aumeunier made changes -
          Fix Version/s New: 4.9.0 [ 18890 ]
          Fix Version/s Original: 4.8.0 [ 17990 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.0 [ 17990 ]
          Fix Version/s Original: 4.7.0 [ 17704 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.7.0 [ 17704 ]
          Fix Version/s Original: 4.6.0 [ 16903 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.6.0 [ 16903 ]
          Fix Version/s Original: 4.5.0 [ 16182 ]
          Cédric Damioli made changes -
          Fix Version/s New: 4.5.0 [ 16182 ]
          Fix Version/s Original: 4.4.0 [ 15598 ]
          Caroline Bayle made changes -
          Fix Version/s New: 4.4.0 [ 15598 ]
          Fix Version/s Original: 4.LATER [ 13984 ]
          Raphaël Franchet made changes -
          Estimation New: 2 - Normal [ 10220 ]
          Internal review New: 1 - Middle term [ 10216 ]
          Caroline Bayle made changes -
          Link New: This issue Référence CMS-10299 [ CMS-10299 ]
          Caroline Bayle created issue -

            cbayle Caroline Bayle
            cbayle Caroline Bayle
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: