[CMS-11005] Unable to modify a content with a link to a content that does not exist anymore

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 4.5.0
Affects Version/s: 4.5.0
Component/s: None
Labels:
None

Sprint:
4.5 M8

On deleting a content linked to another content, the link can be still there after the content deletion because of several reasons like a problem on lock or rights.

But, the invalid value in the attribute should be ignored.

Currently, we get the following error on editing the content:

Une erreur est survenue : elle a empêché de créer le formulaire de modification du contenu 'content://2c808ca1-d78b-4c10-a492-818aec51d750'
dc4e593d-c530-466e-83c7-6ac6d9dfed4d
org.apache.jackrabbit.core.state.NoSuchItemStateException: dc4e593d-c530-466e-83c7-6ac6d9dfed4d
    at org.apache.jackrabbit.core.persistence.bundle.AbstractBundlePersistenceManager.load(AbstractBundlePersistenceManager.java:492)
    at org.apache.jackrabbit.core.state.SharedItemStateManager.loadItemState(SharedItemStateManager.java:1878)
    at org.apache.jackrabbit.core.state.SharedItemStateManager.getNonVirtualItemState(SharedItemStateManager.java:1798)
    at org.apache.jackrabbit.core.state.SharedItemStateManager.getItemState(SharedItemStateManager.java:271)
    at org.apache.jackrabbit.core.state.LocalItemStateManager.getNodeState(LocalItemStateManager.java:110)
    at org.apache.jackrabbit.core.state.LocalItemStateManager.getItemState(LocalItemStateManager.java:175)
    at org.apache.jackrabbit.core.state.XAItemStateManager.getItemState(XAItemStateManager.java:260)
    at org.apache.jackrabbit.core.state.SessionItemStateManager.getItemState(SessionItemStateManager.java:161)
    at org.apache.jackrabbit.core.ItemManager.getItemData(ItemManager.java:382)
    at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:328)
    at org.apache.jackrabbit.core.ItemManager.getItem(ItemManager.java:621)
    at org.apache.jackrabbit.core.SessionImpl.getNodeById(SessionImpl.java:538)
    at org.apache.jackrabbit.core.SessionImpl.getNodeByIdentifier(SessionImpl.java:1142)
    at org.ametys.plugins.repository.jcr.SimpleAmetysObjectFactory.getNode(SimpleAmetysObjectFactory.java:176)
    at org.ametys.plugins.repository.jcr.SimpleAmetysObjectFactory.getAmetysObjectById(SimpleAmetysObjectFactory.java:137)
    at org.ametys.plugins.repository.jcr.SimpleAmetysObjectFactory.getAmetysObjectById(SimpleAmetysObjectFactory.java:58)
    at org.ametys.plugins.repository.AmetysObjectResolver.resolveById(AmetysObjectResolver.java:360)
    at org.ametys.cms.data.ContentValue.getContent(ContentValue.java:120)
    at org.ametys.cms.data.type.AbstractContentElementType._content2JsonForClient(AbstractContentElementType.java:139)
    at org.ametys.cms.data.type.AbstractContentElementType.lambda$_valueToJSON$6(AbstractContentElementType.java:212)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
    at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
    at org.ametys.cms.data.type.AbstractContentElementType._valueToJSON(AbstractContentElementType.java:213)
    at org.ametys.cms.data.type.AbstractContentElementType.valueToJSONForClient(AbstractContentElementType.java:128)
    at org.ametys.core.model.type.AbstractElementType._valueToSAXForEdition(AbstractElementType.java:324)
    at org.ametys.core.model.type.AbstractElementType._valueToSAX(AbstractElementType.java:293)
    at org.ametys.core.model.type.AbstractElementType.valueToSAXForEdition(AbstractElementType.java:263)
    at org.ametys.plugins.repository.data.holder.impl.DataHolderHelper.dataToSAX(DataHolderHelper.java:461)
    at org.ametys.cms.data.type.impl.CompositeRepositoryModelItemType._valueToSAX(CompositeRepositoryModelItemType.java:74)
    at org.ametys.cms.data.type.impl.CompositeRepositoryModelItemType.valueToSAXForEdition(CompositeRepositoryModelItemType.java:48)
    at org.ametys.plugins.repository.data.holder.impl.DataHolderHelper.dataToSAX(DataHolderHelper.java:461)
    at org.ametys.plugins.repository.data.holder.impl.DataHolderHelper.dataToSAX(DataHolderHelper.java:476)
    at org.ametys.plugins.repository.data.holder.ModelAwareDataHolder.dataToSAXForEdition(ModelAwareDataHolder.java:414)
    at org.ametys.cms.content.ContentSaxer.saxAttributes(ContentSaxer.java:333)
    at org.ametys.cms.content.ContentSaxer.saxBody(ContentSaxer.java:167)
    at org.ametys.cms.content.ContentSaxer.saxContent(ContentSaxer.java:142)
    at org.ametys.cms.content.ContentGenerator._saxContent(ContentGenerator.java:121)
    at org.ametys.cms.content.ContentGenerator._generateContent(ContentGenerator.java:86)
    at org.ametys.cms.content.ContentGenerator.generate(ContentGenerator.java:70)
    at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.processXMLPipeline(AbstractProcessingPipeline.java:581)
    at org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.processXMLPipeline(AbstractCachingProcessingPipeline.java:301)
    at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.process(AbstractProcessingPipeline.java:483)
    at org.apache.cocoon.components.source.impl.SitemapSource.getInputStream(SitemapSource.java:267)
    at org.ametys.core.ui.dispatcher.DispatchGenerator._dispatching(DispatchGenerator.java:157)
    at org.ametys.core.ui.dispatcher.DispatchGenerator.generate(DispatchGenerator.java:95)
    at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.processXMLPipeline(AbstractProcessingPipeline.java:581)
    at org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.processXMLPipeline(AbstractCachingProcessingPipeline.java:301)
    at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.process(AbstractProcessingPipeline.java:483)
    at org.apache.cocoon.components.treeprocessor.sitemap.SerializeNode.invoke(SerializeNode.java:144)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:47)
    at org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke(MatchNode.java:108)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:236)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:178)
    at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254)
    at org.apache.cocoon.components.treeprocessor.sitemap.MountNode.invoke(MountNode.java:118)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:47)
    at org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke(MatchNode.java:108)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:236)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:178)
    at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254)
    at org.apache.cocoon.components.treeprocessor.sitemap.MountNode.invoke(MountNode.java:118)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:47)
    at org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke(MatchNode.java:108)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:143)
    at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:69)
    at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:93)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:236)
    at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:178)
    at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:254)
    at org.apache.cocoon.Cocoon.process(Cocoon.java:699)
    at org.ametys.runtime.servlet.RuntimeServlet.service(RuntimeServlet.java:580)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
    at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:688)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
    at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:375)
    at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
    at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
    at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1639)
    at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
    at java.base/java.lang.Thread.run(Thread.java:829)

I think that AbstractContentElementType#_content2JsonForClient() should call ContentValue#getContentIfExists() instead of ContentValue#getContent().

NB: We may have similar behaviour by displaying a content in the live workspace having links to not validated contents.

Bérénice Maurel made changes - 22/Feb/22 19:55

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]

Bérénice Maurel made changes - 04/Jan/22 19:16

Resolution		New: Fixed [ 1 ]
Status	Original: Ready to merge [ 10208 ]	New: Resolved [ 5 ]

Bérénice Maurel made changes - 04/Jan/22 19:16

Assignee

Original: Bérénice Maurel [ bmaurel ]

New: Caroline Bayle [ cbayle ]

Bérénice Maurel made changes - 04/Jan/22 19:16

Status

Original: Code review OK [ 10206 ]

New: Ready to merge [ 10208 ]

Bérénice Maurel made changes - 04/Jan/22 15:32

Status

Original: Available for review [ 10005 ]

New: Code review OK [ 10206 ]

Caroline Bayle made changes - 04/Jan/22 13:53

Assignee

Original: Caroline Bayle [ cbayle ]

New: Bérénice Maurel [ bmaurel ]

Caroline Bayle made changes - 04/Jan/22 13:53

Status

Original: In Progress [ 3 ]

New: Available for review [ 10005 ]

Bérénice Maurel made changes - 04/Jan/22 12:04

Assignee	Original: Bérénice Maurel [ bmaurel ]	New: Caroline Bayle [ cbayle ]
Status	Original: Available for review [ 10005 ]	New: In Progress [ 3 ]

Caroline Bayle made changes - 04/Jan/22 11:06

Assignee

Original: Caroline Bayle [ cbayle ]

New: Bérénice Maurel [ bmaurel ]

Caroline Bayle made changes - 04/Jan/22 11:06

Status

Original: In Progress [ 3 ]

New: Available for review [ 10005 ]

Assignee:: Caroline Bayle

Reporter:: Bérénice Maurel

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 03/Jan/22 17:40

Updated:: 22/Feb/22 19:55

Resolved:: 04/Jan/22 19:16

Details

Description

Attachments

Activity

People

Dates

Contact Product Support