Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-11422

Property should not override getCriterionEnumerator()

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • 4.6.0
    • 4.6.0
    • None
    • None
    • 4.6 M6

      Currently, if you want to have a property which is not of type "content", "user" or "boolean", your property has to be enumerated.

      To write the facet, you have to implement getEnumerator() or to set an enumerator on configuration with method setEnumerator().

      But to read the facet, you also have to implement getCriterionEnumerator() because Property interface has a default implementation returning null (which override (with no reason) default implementation from ElementDefinition which calling getEnumerator()).
      This enumerator should supports the old API because it is like this in AbstractSearchUICriterion.configureEnumerator(...).

      Also, we should have a simply enumerator which only manage the self value to make a property easily facetable.

          [CMS-11422] Property should not override getCriterionEnumerator()

          Bérénice Maurel made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Bérénice Maurel made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Code review OK [ 10206 ] New: Resolved [ 5 ]
          Bérénice Maurel made changes -
          Status Original: Available for review [ 10005 ] New: Code review OK [ 10206 ]
          Bérénice Maurel made changes -
          Status Original: In Progress [ 3 ] New: Available for review [ 10005 ]
          Bérénice Maurel made changes -
          Status Original: Functional review OK [ 10207 ] New: In Progress [ 3 ]
          Bérénice Maurel made changes -
          Summary Original: Make an easier way to have facetable string properties New: Property should not override getCriterionEnumerator()
          Bérénice Maurel made changes -
          Assignee New: Bérénice Maurel [ bmaurel ]
          Bérénice Maurel made changes -
          Status Original: Available for review [ 10005 ] New: Functional review OK [ 10207 ]
          Bérénice Maurel made changes -
          Assignee Original: Bérénice Maurel [ bmaurel ]
          Bérénice Maurel made changes -
          Status Original: Open [ 1 ] New: Available for review [ 10005 ]

            bmaurel Bérénice Maurel
            bmaurel Bérénice Maurel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: