• Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • 3.9
    • None
    • None
    • None

        [CMS-5430] Migrate pipelines to callable

        The patch "pipeline_cleaning_comments" also contains the migration of the content consistency functionnalities to callable methods.
        The actions and pipelines implementing the edition, validation, invalidation or deletion of a comment have been migrated to CommentClientSideElement. However, the pipeline comments/list.xml is used in the project Runtime so the generator hasn't been removed.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited The patch "pipeline_cleaning_comments" also contains the migration of the content consistency functionnalities to callable methods. The actions and pipelines implementing the edition, validation, invalidation or deletion of a comment have been migrated to CommentClientSideElement . However, the pipeline comments/list.xml is used in the project Runtime so the generator hasn't been removed.

        Removal of the consistency/engine-state and consistency/start-report pipelines. Those functionnalites are now coded in callable methods within the Avalon component ContentConsistencyHelper. The associated pipelines, generator and action have been removed as well.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited Removal of the consistency/engine-state and consistency/start-report pipelines. Those functionnalites are now coded in callable methods within the Avalon component ContentConsistencyHelper . The associated pipelines, generator and action have been removed as well.

        Removal of the pipeline archives/schedule/get-date, the functionnality is now a callable coded in ScheduledArchivingClientSideElement

        Quentin Glinel-Mortreuil (Inactive) added a comment - Removal of the pipeline archives/schedule/get-date, the functionnality is now a callable coded in ScheduledArchivingClientSideElement

        Laurence Aumeunier added a comment - - edited

        The following pipelines should be also migrated:

        • metadata-set/definition.json (TreeStore)
        • content/auto-backup.xml
        • content/set-auto-backup
        • simple-content/import ? (form multipart)
        • archives/schedule/set-date
        • archives/schedule/get-date (see org.ametys.cms.clientsideelement.ScheduleArchivingClientSideElement)
        • content-types/hierarchie (TreeStore)
        • explorer/root (synchrone)
        • consistency/start-report
        • consistency/engine-state
        • comments/list.xml (tree store)
        • comments/validate-comment
        • comments/invalidate-comment
        • comments/delete-comment
        • comments/edit-comment

        Laurence Aumeunier added a comment - - edited The following pipelines should be also migrated: metadata-set/definition.json (TreeStore) content/auto-backup.xml content/set-auto-backup simple-content/import ? (form multipart) archives/schedule/set-date archives/schedule/get-date (see org.ametys.cms.clientsideelement.ScheduleArchivingClientSideElement ) content-types/hierarchie (TreeStore) explorer/root (synchrone) consistency/start-report consistency/engine-state comments/list.xml (tree store) comments/validate-comment comments/invalidate-comment comments/delete-comment comments/edit-comment

        pipeline_cleaning10

        Gathers patches 4 to 10.

        The addContentType and removeContentType methods from the ContentTypeActions.i18n.js are now using the same callable method. The 2 pipelines and the action used before have been removed.

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning10 Gathers patches 4 to 10. The addContentType and removeContentType methods from the ContentTypeActions.i18n.js are now using the same callable method. The 2 pipelines and the action used before have been removed.

        pipeline_cleaning9 :

        Gathers patches 4 to 9.
        SelectContentBySearch now uses a callable method instead of a pipeline.

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning9 : Gathers patches 4 to 9. SelectContentBySearch now uses a callable method instead of a pipeline.

        pipeline_cleaning8

        This patch gathers all the modifications made from the 4th patch up to this one. It has migrated the ServerComm.send of the SearchTool to a Callable method. The associated pipeline and action have been removed.

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning8 This patch gathers all the modifications made from the 4th patch up to this one. It has migrated the ServerComm.send of the SearchTool to a Callable method. The associated pipeline and action have been removed.

        pipeline_cleaning7

        This patch adds the migration of the 2 pipelines : "duplication/create/* " and "duplication/edit/* " to 2 callable methods in CreateContentByCopy and EditContentByCopy respectively. The associated actions and pipelines have been removed.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited pipeline_cleaning7 This patch adds the migration of the 2 pipelines : "duplication/create/* " and "duplication/edit/* " to 2 callable methods in CreateContentByCopy and EditContentByCopy respectively. The associated actions and pipelines have been removed.

        pipeline_cleaning6

        This patch gathers several operations used in the "Parameter files" tab in one ClientSideElement ( ParametersClientSideElement ). The associated actions and pipelines have been removed.
        This patch contains only the modifications made for the "Parameter files" tab, I made the mistake of unchecking the files that were patched with pipeline_cleaning4 and pipeline_cleaning5 when i generated the patch. (again..)

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited pipeline_cleaning6 This patch gathers several operations used in the "Parameter files" tab in one ClientSideElement ( ParametersClientSideElement ). The associated actions and pipelines have been removed. This patch contains only the modifications made for the "Parameter files" tab, I made the mistake of unchecking the files that were patched with pipeline_cleaning4 and pipeline_cleaning5 when i generated the patch. (again..)

        pipeline_cleaning_improved_naming

        this patch renames classes and methods for the "see user's rights" functionnality

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning_improved_naming this patch renames classes and methods for the "see user's rights" functionnality

        pipeline_cleaning5

        This patch replaces two ServerComm.send with 2 serverCall from the ButtonController ( file SaveAction.i18n.js). The pipeline (url = "delete-auto-backup" ) and associated action ("DeleteContentAutoBackp.java") have been removed and a feature ("DeleteContentBackupClientSideElement") has been added to replace it.

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning5 This patch replaces two ServerComm.send with 2 serverCall from the ButtonController ( file SaveAction.i18n.js). The pipeline (url = "delete-auto-backup" ) and associated action ("DeleteContentAutoBackp.java") have been removed and a feature ("DeleteContentBackupClientSideElement") has been added to replace it.

        Could you please attach your runtime patch in https://issues.ametys.org/browse/RUNTIME-1037 issue ?

        Laurence Aumeunier added a comment - Could you please attach your runtime patch in https://issues.ametys.org/browse/RUNTIME-1037 issue ?

        pipeline_cleaning4

        This patch gets rid of 2 pipelines ( url = "profile.xml" and url ="user/rights.xml" ) and the 2 associated generators as well as .xsl file for the profile. The serverCalls are now callMethod, and the plugin has been modified accordingly. A method toJSON has been written in the Runtime file Right.java as a helper to structure the server's response.

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning4 This patch gets rid of 2 pipelines ( url = "profile.xml" and url ="user/rights.xml" ) and the 2 associated generators as well as .xsl file for the profile. The serverCalls are now callMethod, and the plugin has been modified accordingly. A method toJSON has been written in the Runtime file Right.java as a helper to structure the server's response.

        Patchs 1,2 and 3 have been applied

        Laurence Aumeunier added a comment - Patchs 1,2 and 3 have been applied

        pipeline_cleaning123.patch

        This patch gathers the modifications made in the 3 first patches.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited pipeline_cleaning123.patch This patch gathers the modifications made in the 3 first patches.

        pipeline_cleaning3.patch

        3 ServerComm.send using the same pipeline ( url = "unlock-content" ) replaced with 3 ServerComm.callMethod. The associated pipeline and Action (UnlockOrLockAction) have been removed. The Avalon component UnlockOrLock has been added in the plugin ( feature name = "lock-unlock" ).

        Quentin Glinel-Mortreuil (Inactive) added a comment - pipeline_cleaning3.patch 3 ServerComm.send using the same pipeline ( url = "unlock-content" ) replaced with 3 ServerComm.callMethod. The associated pipeline and Action (UnlockOrLockAction) have been removed. The Avalon component UnlockOrLock has been added in the plugin ( feature name = "lock-unlock" ).

        pipeline_cleaning2.patch

        ServerComm.send in ParametersActions.i18n.js is now a serverCall. The corresponding pipeline ( url : "param/save" ) has been removed as well as the associated action : SaveParameterFileAction.java. The methods save and saveAndQuit are now using the callable function
        "saveParameters" in "ParametersClientSideElement.java", and the plugin has been modified accordingly.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited pipeline_cleaning2.patch ServerComm.send in ParametersActions.i18n.js is now a serverCall. The corresponding pipeline ( url : "param/save" ) has been removed as well as the associated action : SaveParameterFileAction.java. The methods save and saveAndQuit are now using the callable function "saveParameters" in "ParametersClientSideElement.java", and the plugin has been modified accordingly.

        The removed pipelines might be used elsewhere, so these patches may cause errors.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited The removed pipelines might be used elsewhere, so these patches may cause errors.

        pipeline_cleaning1_cms.patch

        First patch, containing modifications on the sitemap ( 4 pipelines deleted ), new ClientSideElements, and 4 ServerComm.send replaced by 2 callMethod and 2 serverCall. However, actions can't be removed yet because they are still used by other functions.

        Quentin Glinel-Mortreuil (Inactive) added a comment - - edited pipeline_cleaning1_cms.patch First patch, containing modifications on the sitemap ( 4 pipelines deleted ), new ClientSideElements, and 4 ServerComm.send replaced by 2 callMethod and 2 serverCall. However, actions can't be removed yet because they are still used by other functions.

          quentin Quentin Glinel-Mortreuil (Inactive)
          quentin Quentin Glinel-Mortreuil (Inactive)
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Created:
            Updated:
            Resolved: