Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-9706

[Site configuration] Include site illustration to the model

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • 4.3.0
    • 4.2.0
    • None
    • None
    • 4.3 M1

      The acces to the site illustration has not been migrated because the illustration is not part of the model.

      The use of the new API in SiteConfigurationExtensionPoint is to review:

      • SiteParameter does not extend CategorizedElementDefinition
      • Use the CategorizedElementDefinitionHelper instead of re-implement the 'categorize' and co methods
      • Use a view to call the toJSON method on it
      • Remove the illustration from the view (except if the binary.fromJSON is well implemented)
      • Insert the language parameter after the skin one (or put it in the model?) Insert it via a ModelItem (take care of validators and enumerators..)
      • Be careful to not break the sort of the parameters (there is a comparator in SiteConfigurationExtensionPoint but I don't know what it was used for)

          [CMS-9706] [Site configuration] Include site illustration to the model

          Caroline Bayle made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Caroline Bayle made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Ready to merge [ 10208 ] New: Resolved [ 5 ]
          Caroline Bayle made changes -
          Assignee New: Caroline Bayle [ cbayle ]
          Thibaut Bergé (Inactive) made changes -
          Status Original: Code review OK [ 10206 ] New: Ready to merge [ 10208 ]
          Caroline Bayle made changes -
          Assignee Original: Caroline Bayle [ cbayle ]
          Caroline Bayle made changes -
          Status Original: Available for review [ 10005 ] New: Code review OK [ 10206 ]
          Caroline Bayle made changes -
          Status Original: In Progress [ 3 ] New: Available for review [ 10005 ]
          Caroline Bayle made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Raphaël Franchet made changes -
          Status Original: Available for review [ 10005 ] New: Open [ 1 ]
          Raphaël Franchet made changes -
          Assignee Original: Raphaël Franchet [ raphael ] New: Caroline Bayle [ cbayle ]

            cbayle Caroline Bayle
            cbayle Caroline Bayle
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: