Uploaded image for project: 'Newsletter'
  1. Newsletter
  2. NEWSLETTER-289

AutomaticNewslettersScheduler and validateActionIds

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • 2.14.0
    • 2.5.0
    • None

      The plugin newsletter defines the component:

      <component role="org.ametys.plugins.newsletter.auto.AutomaticNewslettersScheduler"
                  		   id="org.ametys.plugins.newsletter.auto.AutomaticNewslettersScheduler"
                             class="org.ametys.plugins.newsletter.auto.AutomaticNewslettersScheduler"
                             logger="org.ametys.plugins.newsletter.auto.AutomaticNewslettersScheduler">
                      <workflow name="newsletter" initialActionId="1" validateActionIds="3,4"/>
                  </component> 

       

      And with demo data, workflows/newsletter.xml does not define a "3" action id

      Thus, with a newsletter auto, I'v got the following error :

      2019-04-09 15:07:02,413 ERROR [org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine] (AutomaticNewslettersEngine;/cms/_admin/plugins/admin/config/set) An error occurred creating the automatic newsletter contents.
      com.opensymphony.workflow.InvalidActionException: Action 3 is invalid
      	at com.opensymphony.workflow.AbstractWorkflow.doAction(AbstractWorkflow.java:562)
      	at org.ametys.plugins.workflow.AbstractAmetysWorkflow.doAction(AbstractAmetysWorkflow.java:164)
      	at org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine.validateNewsletter(AutomaticNewslettersEngine.java:516)
      	at org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine.createAndValidateAutomaticNewsletter(AutomaticNewslettersEngine.java:371)
      	at org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine.createAutomaticNewsletters(AutomaticNewslettersEngine.java:334)
      	at org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine.createAutomaticNewsletters(AutomaticNewslettersEngine.java:300)
      	at org.ametys.plugins.newsletter.auto.AutomaticNewslettersEngine.run(AutomaticNewslettersEngine.java:234)
      	at java.lang.Thread.run(Thread.java:745) 

      While it should check among "3" and "4" action ids before trying to execute them

          [NEWSLETTER-289] AutomaticNewslettersScheduler and validateActionIds

          Raphaël Franchet made changes -
          Fix Version/s New: 2.14.0 [ 19099 ]
          Fix Version/s Original: 2.13.0 [ 19009 ]
          Cédric Damioli made changes -
          Fix Version/s New: 2.13.0 [ 19009 ]
          Fix Version/s Original: 2.12.0 [ 18914 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 2.12.0 [ 18914 ]
          Fix Version/s Original: 2.11.0 [ 18020 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 2.11.0 [ 18020 ]
          Fix Version/s Original: 2.10.0 [ 17731 ]
          Cédric Damioli made changes -
          Fix Version/s New: 2.10.0 [ 17731 ]
          Fix Version/s Original: 2.9.0 [ 16945 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 2.9.0 [ 16945 ]
          Fix Version/s Original: 2.8.0 [ 16385 ]
          Cédric Damioli made changes -
          Fix Version/s New: 2.8.0 [ 16385 ]
          Fix Version/s Original: 2.7.0 [ 15620 ]
          Cédric Damioli made changes -
          Fix Version/s New: 2.7.0 [ 15620 ]
          Fix Version/s Original: 2.6.0 [ 15238 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 2.6.0 [ 15238 ]
          Fix Version/s Original: 2.5.0 [ 14554 ]
          Simon Prieul (Inactive) created issue -

            Unassigned Unassigned
            sprieul Simon Prieul (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: