Uploaded image for project: 'Runtime'
  1. Runtime
  2. RUNTIME-1142 FormEditionPanel
  3. RUNTIME-1296

_compareByOrder not working for JSON inputs

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Major Major
    • 4.0 alpha
    • None
    • None
    • None

      In ConfigurableFormPanel#_compareByOrder :

              var aOrder = Ext.dom.Query.selectValue('order', a) || a.order;
        var bOrder = Ext.dom.Query.selectValue('order', b) || b.order;

      instead of

              var aOrder = Ext.dom.Query.selectValue('order', a);
        var bOrder = Ext.dom.Query.selectValue('order', b);

        1. RUNTIME_ConfigurableFormPanel_compareByOrder.patch
          4 kB

          [RUNTIME-1296] _compareByOrder not working for JSON inputs

          Quentin Glinel-Mortreuil (Inactive) made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Raphaël Franchet made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Patch available [ 10005 ] New: Resolved [ 5 ]
          Quentin Glinel-Mortreuil (Inactive) made changes -
          Status Original: Open [ 1 ] New: Patch available [ 10005 ]
          Quentin Glinel-Mortreuil (Inactive) made changes -
          Attachment New: RUNTIME_ConfigurableFormPanel_compareByOrder.patch [ 16572 ]

          Quentin Glinel-Mortreuil (Inactive) added a comment -

          Yes, using _isElement. I also noticed that parameter checkers for groups were not sorted for the XML configuration, which is fixed in this patch as well

          Quentin Glinel-Mortreuil (Inactive) added a comment - Yes, using _isElement. I also noticed that parameter checkers for groups were not sorted for the XML configuration, which is fixed in this patch as well
          Raphaël Franchet made changes -
          Status Original: Patch available [ 10005 ] New: Open [ 1 ]

          Raphaël Franchet added a comment -

          is it possible to do better by testing if "a" is an xml node, instead of trying to selectValue on it

          Raphaël Franchet added a comment - is it possible to do better by testing if "a" is an xml node, instead of trying to selectValue on it
          Quentin Glinel-Mortreuil (Inactive) made changes -
          Description Original:
          {code:javascript}
                  var aOrder = Ext.dom.Query.selectValue('order', a) || a.order;
                  var bOrder = Ext.dom.Query.selectValue('order', b) || b.order;
          {code}

          instead of

          {code:javascript}
                  var aOrder = Ext.dom.Query.selectValue('order', a);
                  var bOrder = Ext.dom.Query.selectValue('order', b);
          {code}           		New: In ConfigurableFormPanel#_compareByOrder :

          {code:javascript}
                  var aOrder = Ext.dom.Query.selectValue('order', a) || a.order;
                  var bOrder = Ext.dom.Query.selectValue('order', b) || b.order;
          {code}

          instead of

          {code:javascript}
                  var aOrder = Ext.dom.Query.selectValue('order', a);
                  var bOrder = Ext.dom.Query.selectValue('order', b);
          {code}
          Quentin Glinel-Mortreuil (Inactive) made changes -
          Status Original: Open [ 1 ] New: Patch available [ 10005 ]
          Quentin Glinel-Mortreuil (Inactive) created issue -

            raphael Raphaël Franchet
            quentin Quentin Glinel-Mortreuil (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: