Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-3788

Service xslt view in the skin should not hardcode the skin name

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • 3.5
    • None
    • Plugin : Web
    • None

      Currently, when you add a view for a service in the skin, you add a xslt file and a xml file.
      In the xml file when you use an i18n key, you have to specify the catalogue "skin.MYSKIN:", because the default catalogue is the one of the plugin creating the view.

      This is not a problem when parsing the xslt file because you have a variable $skin, but in this xml file...

      This become critical for generated skins: in the 3.4 blog skin , you will find a "skin.demo:XXXXX" for example.

      A way to correct this could be in the ServiceXSLTEnumerator to change the _parseI18nizableText method by giving it the defaultCatalogue that can be computed above BUT this imply an API change

          [CMS-3788] Service xslt view in the skin should not hardcode the skin name

          Raphaël Franchet added a comment -

          in 3.5, skin will be the default catalogue for files in the skin or template.
          for previous version, skin name has to be hardcoded

          Raphaël Franchet added a comment - in 3.5, skin will be the default catalogue for files in the skin or template. for previous version, skin name has to be hardcoded

            raphael Raphaël Franchet
            raphael Raphaël Franchet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: