Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-4161

ToolsManager and slideIn

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 4.2.0
    • None
    • None
    • None

      The org.ametys.uitool.ToolsManager.prototype.slideInOtherRegionsOnFocus method is not future proof.

      panelHierarchy is currently simple (center, east, west, north, south) but is coded to be more complex in the future (with center-right for example)

      current code is not taking this in account

      here is a fix that require to be tested

      org.ametys.uitool.ToolsManager.prototype.slideInOtherRegionsOnFocus  = function (panel)
      {
      	for (var i in this._panelHierarchy)
      	{
      		if (this._panelHierarchy[i] != panel && panel.getLayout().isSlid)
      		{
      			panel.getLayout().slideIn();
      		}
      	}
      }
      

      This code is simplier and generic!

            Unassigned Unassigned
            raphael Raphaƫl Franchet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: