• Type: Improvement
• Resolution: Fixed
• Priority: Major
• Fix Version/s: 3.7
• Affects Version/s: None
• Component/s: None
• Labels:

  None

1. Ametys - 07 CMS.patch

   18 kB

   08/Jul/14 16:43

2. Search_CMS.patch

   14 kB

   15/Jul/14 13:30

3. Search_WEB.patch

   11 kB

   15/Jul/14 13:30

4. Search - 08 WEB.patch

   19 kB

   17/Jul/14 17:03

5. SearchDate_CMS.patch

   16 kB

   13/Jun/14 16:05

6. SearchDate_WEB.patch

   29 kB

   13/Jun/14 16:05

[CMS-5540] Service search by date

Collapse comment: Raphaël Franchet added a comment - 16/Jul/14 19:32

Raphaël Franchet added a comment - 16/Jul/14 19:32

The web patch is also partial and non working.
Could you update, and give a full patch, plz ?
Thks

Expand comment: Raphaël Franchet added a comment - 16/Jul/14 19:32

Raphaël Franchet added a comment - 16/Jul/14 19:32 The web patch is also partial and non working. Could you update, and give a full patch, plz ? Thks

Collapse comment: Raphaël Franchet added a comment - 16/Jul/14 19:22

Raphaël Franchet added a comment - 16/Jul/14 19:22

First, when you submit a patch it has to be complete. The CMS patch is partial.

CMS
1) I found some "console.log" ! in the patch of the js file.
2) The js file has to be statically imported as others widgets are
3) In org.ametys.servercomm.ServerComm.handleBadResponse, the last argument is a logger category, should be the current class, not the class where you copy the source from
4) All files must end with a line-return
5) In java, please set licence date to 2014
6) In java, please organise imports
7) When you set a FIXME with a ticket, insert the ticket number. eg.

// FIXME CMS-5573 Indexation lucene Repeater

and not

//FIXME cf Patch Indexation lucene Repeater

I applied the patch to CMS

Expand comment: Raphaël Franchet added a comment - 16/Jul/14 19:22

Raphaël Franchet added a comment - 16/Jul/14 19:22 First, when you submit a patch it has to be complete. The CMS patch is partial. CMS 1) I found some "console.log" ! in the patch of the js file. 2) The js file has to be statically imported as others widgets are 3) In org.ametys.servercomm.ServerComm.handleBadResponse, the last argument is a logger category, should be the current class, not the class where you copy the source from 4) All files must end with a line-return 5) In java, please set licence date to 2014 6) In java, please organise imports 7) When you set a FIXME with a ticket, insert the ticket number. eg. // FIXME CMS-5573 Indexation lucene Repeater and not //FIXME cf Patch Indexation lucene Repeater I applied the patch to CMS

Collapse comment: Raphaël Franchet added a comment - 08/Jul/14 16:43

Raphaël Franchet added a comment - 08/Jul/14 16:43

Here is a modified patch for the CMS only with lots of TODO in the java please consider it

Expand comment: Raphaël Franchet added a comment - 08/Jul/14 16:43

Raphaël Franchet added a comment - 08/Jul/14 16:43 Here is a modified patch for the CMS only with lots of TODO in the java please consider it