Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-5571

The fix for Pirobox to be compatible with jquery 1.8 is bad

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.7, 3.9
    • None
    • None

    Description

      It creates $j.browser the wrong way should be like in jquery-migrate

      matched = jQuery.uaMatch( navigator.userAgent );
      	browser = {};
      
      	if ( matched.browser ) {
      		browser[ matched.browser ] = true;
      		browser.version = matched.version;
      	}
      
      	// Chrome is Webkit, but Webkit is also Safari.
      	if ( browser.chrome ) {
      		browser.webkit = true;
      	} else if ( browser.webkit ) {
      		browser.safari = true;
      	}
      
      	jQuery.browser = browser;
      	
      

      Attachments

        Activity

          People

            trizzi Thibaut Rizzi (Inactive)
            llopez Laure Lopez
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: