Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-5571

The fix for Pirobox to be compatible with jquery 1.8 is bad

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.7, 3.9
    • None
    • None
    • None

      It creates $j.browser the wrong way should be like in jquery-migrate

      matched = jQuery.uaMatch( navigator.userAgent );
	browser = {};

	if ( matched.browser ) {
		browser[ matched.browser ] = true;
		browser.version = matched.version;
	}

	// Chrome is Webkit, but Webkit is also Safari.
	if ( browser.chrome ) {
		browser.webkit = true;
	} else if ( browser.webkit ) {
		browser.safari = true;
	}

	jQuery.browser = browser;

          [CMS-5571] The fix for Pirobox to be compatible with jquery 1.8 is bad

          Laurence Aumeunier made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Thibaut Rizzi (Inactive) made changes -
          Fix Version/s New: 3.9 [ 11927 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Raphaël Franchet made changes -
          Status Original: Feedback required [ 10000 ] New: Open [ 1 ]
          Raphaël Franchet made changes -
          Assignee Original: Raphaël Franchet [ raphael ] New: Thibaut Rizzi [ trizzi ]
          Thibaut Rizzi (Inactive) made changes -
          Assignee Original: Thibaut Rizzi [ trizzi ] New: Raphaël Franchet [ raphael ]
          Status Original: Open [ 1 ] New: Feedback required [ 10000 ]
          Laurence Aumeunier made changes -
          Assignee New: Thibaut Rizzi [ trizzi ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 3.6 [ 11785 ]
          Laure Lopez created issue -

            trizzi Thibaut Rizzi (Inactive)
            llopez Laure Lopez
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: