• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: 4.1.0
• Affects Version/s: 4.1.0
• Component/s: None
• Labels:

  None
• Environment:

  4.1RC1

1. 

   image-2018-02-12-14-25-07-792.png

   12 kB

   12/Feb/18 14:25

[CMS-9008] Ext.grid.header.Container multiple logs in solr search

Collapse comment: Simon Prieul (Inactive) added a comment - 21/Feb/18 14:12

Simon Prieul (Inactive) added a comment - 21/Feb/18 14:12

I think it is an ExtJS bug

Indeed, in src/panel/Table.js in lines 2253 and 2254 in reconfigure method, ExtJS does

headerCt.removeAll();
headerCt.add(columns);

nothing wrong here

but if we investigate deeper, in src/grid/header/Container.js in line 787 in onRemove method it does

delete me._usedIDs[c.headerId];

whereas in line 702 in onAdd method, it does

var stateId = c.getStateId();
if (me._usedIDs[stateId] && me._usedIDs[stateId] !== c)

So in my opinion, there is here a problem of consistency with the keys of the cache object _usedIDs. The onRemove method should do

delete me._usedIDs[c.getStateId()];

So I propose to open an issue for ExtJS + the workaround in the attached branch

Expand comment: Simon Prieul (Inactive) added a comment - 21/Feb/18 14:12

Simon Prieul (Inactive) added a comment - 21/Feb/18 14:12 I think it is an ExtJS bug Indeed, in src/panel/Table.js in lines 2253 and 2254 in reconfigure method, ExtJS does headerCt.removeAll(); headerCt.add(columns); nothing wrong here but if we investigate deeper, in src/grid/header/Container.js in line 787 in onRemove method it does delete me._usedIDs[c.headerId]; whereas in line 702 in onAdd method, it does var stateId = c.getStateId(); if (me._usedIDs[stateId] && me._usedIDs[stateId] !== c) So in my opinion, there is here a problem of consistency with the keys of the cache object _usedIDs . The onRemove method should do delete me._usedIDs[c.getStateId()]; So I propose to open an issue for ExtJS + the workaround in the attached branch

Collapse comment: Simon Prieul (Inactive) added a comment - 12/Feb/18 14:54

Simon Prieul (Inactive) added a comment - 12/Feb/18 14:54

I'm quite sure we are getting this logs when doing

this.grid.reconfigure(this.store, columns);

So, every time we click the search button after changing the "columns" criterion

Expand comment: Simon Prieul (Inactive) added a comment - 12/Feb/18 14:54

Simon Prieul (Inactive) added a comment - 12/Feb/18 14:54 I'm quite sure we are getting this logs when doing this .grid.reconfigure( this .store, columns); So, every time we click the search button after changing the "columns" criterion