Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-9897

[Search Service] Add a criteria is adding it before instead after the criteria

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Major Major
    • 4.LATER
    • 4.3.0
    • Plugin : Search
    • None
    • 1 - Middle term
    • 3 - Complex

      When we add a new criteria in the new search service, it is added before the selected criteria. It's disturbing.

      I think a normal behaviour is to add it after the selected criteria, no ?

      Steps to reproduce :

      1. Click on the add button
      2. The new criteria is added before the criteria on which I click on the add button.

        1. NewSearch-Step1.jpg
          15 kB
          Bérénice Maurel
        2. NewSearch-Step2.jpg
          30 kB
          Bérénice Maurel

          [CMS-9897] [Search Service] Add a criteria is adding it before instead after the criteria

          Simon Prieul (Inactive) added a comment - - edited

          Honestly, if UI has to be enhanced, this panel (AvancedSearchFormPanel) should be recoded form scratch.

          Too much work and headaches every time a bug fix or an enhancement is asked.

          The code is full of smell-code, and features were added on the fly making it harder and harder to understand and maintain, adding more and more bad design patterns.

          It's like trying to maintain an elephant on a house of cards.

          Simon Prieul (Inactive) added a comment - - edited Honestly, if UI has to be enhanced, this panel (AvancedSearchFormPanel) should be recoded form scratch. Too much work and headaches every time a bug fix or an enhancement is asked. The code is full of smell-code, and features were added on the fly making it harder and harder to understand and maintain, adding more and more bad design patterns. It's like trying to maintain an elephant on a house of cards.

          Raphaël Franchet added a comment -

          I agree with both of you

          The curren UI is clearly disturbing and should be enhanced...
          maybe we should support drag'and'drop? and the plus should insert after and we would remove the add using the combobox that is non intuituve

          Raphaël Franchet added a comment - I agree with both of you The curren UI is clearly disturbing and should be enhanced... maybe we should support drag'and'drop? and the plus should insert after and we would remove the add using the combobox that is non intuituve

          Simon Prieul (Inactive) added a comment - - edited

          No it was the purpose.
          At the beginning, the icon was an arrow pointing to the top (but was changed due to 'move top' and 'move bottom' buttons which also use arrows).

          The spec said it was for inserting above (look at the tooltip for instance)

          It's because (I guess) the last line is for adding at last, so having a button inserting above enable all kind of insertions.

          Simon Prieul (Inactive) added a comment - - edited No it was the purpose. At the beginning, the icon was an arrow pointing to the top (but was changed due to 'move top' and 'move bottom' buttons which also use arrows). The spec said it was for inserting above (look at the tooltip for instance) It's because (I guess) the last line is for adding at last, so having a button inserting above enable all kind of insertions.

            Unassigned Unassigned
            bmaurel Bérénice Maurel
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: