Uploaded image for project: 'CMS'
  1. CMS
  2. CMS-9920

Comments rendering should not use document.write anymore (for new Search service for example)

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Blocker Blocker
    • 4.10.0
    • None
    • None
    • None

      Before, for accessibility purposes, the comments buttons were added in javascript using "document.write"

       

      Now with the new search engine and the ajax rendering, the "document.write" done after dom load, erase the whole page

       

      Solution 1: stop doing js rendering, since accessibility does not require it anymore. It will make the XSL easy to read

      Solution 2: replace "document.write" with "jQuery.append"

       

      I vote for solution 1.

       

      Also TODO, find all "document.write" in kernel XSL to hunt it (and open other tickets)

          [CMS-9920] Comments rendering should not use document.write anymore (for new Search service for example)

          Laurence Aumeunier made changes -
          Fix Version/s New: 4.10.0 [ 19650 ]
          Fix Version/s Original: 4.9.0 [ 18890 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.9.0 [ 18890 ]
          Fix Version/s Original: 4.8.0 [ 17990 ]
          Laurence Aumeunier made changes -
          Link New: This issue Fait partie de CMS-11824 [ CMS-11824 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.0 [ 17990 ]
          Fix Version/s Original: 4.7.0 [ 17704 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.7.0 [ 17704 ]
          Fix Version/s Original: 4.6.0 [ 16903 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.6.0 [ 16903 ]
          Fix Version/s Original: 4.5.0 [ 16182 ]
          Cédric Damioli made changes -
          Fix Version/s New: 4.5.0 [ 16182 ]
          Fix Version/s Original: 4.4.0 [ 15598 ]
          Raphaël Franchet made changes -
          Summary Original: Comments rendering and new Search service New: Comments rendering should not use document.write anymore (for new Search service for example)
          Raphaël Franchet made changes -
          Priority Original: Major [ 3 ] New: Blocker [ 1 ]
          Raphaël Franchet made changes -
          Fix Version/s New: 4.4.0 [ 15598 ]
          Fix Version/s Original: 4.3.0 [ 14678 ]

            Unassigned Unassigned
            raphael Raphaël Franchet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: