Uploaded image for project: 'Links directory'
  1. Links directory
  2. LINKS-93

The link to add a favorite link use jqtransform whereas our skin does not use this library

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 2.2.0
    • 2.0.0
    • None
    • Chrome
    • 4.1 RC1, 4.1 RC2

      How to reproduce it :

      • in head.xsl comment lines 142 and 177 to 183 :
        <link rel="stylesheet" type="text/css" href="{ametys:skinURL('css/jqtransform.css')}" media="screen,print,handheld"/>
        	<script type="text/javascript" src="{ametys:skinURL('js/jquery.jqtransform.js')}"></script>
           				<script type="text/javascript">
           					$j(function() {
        					    //find all form with class jqtransform and apply the plugin
        					    $j(".ametys-cms-content, .ametys-cms-service").not(".no-jqtransform").find('form').jqTransform();
        					});
           				</script>
      • add a link directory service in a page with all options checked
      • in FO, try to add a favorite link
        > An error has occurred while adding favorite : Uncaught TypeError: $j(...).jqTransform is not a function

      Laurence P. reproduce it with a skin without jqtransform

          [LINKS-93] The link to add a favorite link use jqtransform whereas our skin does not use this library

          The reopen is invalid.
          Now the JS $j('#add-user-link-form-<xsl:value-of select="$userLinkBtnId"/>').jqTransform(); is no more present in link directory plugin, but the demo skin do it in its override of config_utils.xsl (skins\demo\services\link-directory\pages\services\directory\utils\config_utils.xsl)
          So to test it, we also have to comment this line.

          Laurence Aumeunier added a comment - The reopen is invalid. Now the JS $j('#add-user-link-form-<xsl:value-of select="$userLinkBtnId"/>').jqTransform(); is no more present in link directory plugin, but the demo skin do it in its override of config_utils.xsl (skins\demo\services\link-directory\pages\services\directory\utils\config_utils.xsl) So to test it, we also have to comment this line.

          Laure Lopez added a comment -

          I reproduced exactly the scenario written into the ticket and I get this screenshot.

          Laure Lopez added a comment - I reproduced exactly the scenario written into the ticket and I get this screenshot.

          In config_utils.xsl file, the template "add-user-link-btn-script" use jqTransform. It should not.
          The concerned line should be inserted by demo skins.

          Laurence Aumeunier added a comment - In config_utils.xsl file, the template "add-user-link-btn-script" use jqTransform. It should not. The concerned line should be inserted by demo skins.

            laurence Laurence Aumeunier
            llopez Laure Lopez
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: