-
Improvement
-
Resolution: Unresolved
-
Major
-
None
When trying to override the scss theme variables of the Ametys Campus skin (parent skin of my project skin), for instance `$primary`, I must override all the variables that use `$primary` in this same file (and all the variables using these overridden variables).
In this case :
$primary: #0C883D;
$g-color-primary: $primary;
$headings-helper-bg-color: $g-color-primary !default;
$list-helper-bg-color: $g-color-primary;
$list-square-helper-bg-color: $list-helper-bg-color;
$custom-control-indicator-checked-bg: $g-color-primary;
```
It would be better to have 2 differents files. On the first, we put all the variables that don't depends on others, which can be overridden. In the second file, we put all the variables that depends on the first ones.
In this case, I would only have to override `$primary`
[ODF-2634] Improve scss theme variables inheritance
Laurence Aumeunier
made changes -
| Fix Version/s | New: 4.9.0 [ 18934 ] | |
| Fix Version/s | Original: 4.8.0 [ 18045 ] |
Laurence Aumeunier
made changes -
| Fix Version/s | New: 4.8.0 [ 18045 ] | |
| Fix Version/s | Original: 4.7.0 [ 17751 ] |
Cédric Damioli
made changes -
| Fix Version/s | New: 4.7.0 [ 17751 ] | |
| Fix Version/s | Original: 4.6.0 [ 16891 ] |
Laurence Aumeunier
made changes -
| Fix Version/s | New: 4.6.0 [ 16891 ] | |
| Fix Version/s | Original: 4.5.0 [ 16305 ] |
Cédric Damioli
made changes -
| Fix Version/s | New: 4.5.0 [ 16305 ] | |
| Fix Version/s | Original: 4.4.0 [ 15609 ] |
Laurence Perier
made changes -
| Labels | New: SkinDeveloperNeeds |
Raphaël Franchet
made changes -
| Fix Version/s | Original: 4.3.1 [ 15641 ] |
Laurence Aumeunier
made changes -
| Fix Version/s | New: 4.4.0 [ 15609 ] | |
| Fix Version/s | New: 4.3.1 [ 15641 ] |
Laurence Aumeunier
made changes -
| Issue Type | Original: Bug [ 1 ] | New: Improvement [ 4 ] |
Une autre solution serait utiliser $g-color-primary: $primary !default
Dans ce cas c'est la valeur finale de $primary qui serait utilisée et non la valeur définie dans le fichier.
Autre amélioration à apporter dans ce fichier _theme-variables.sccs, les variables du type $g-color-primary-light, $g-color-primary-dark, ... devraient être définies à partir de fonction avec la valeur de $primary.
Il suffirait alors de surcharger _theme-variables.sccs, en ne redéfinissant que la valeur de $primary.