Uploaded image for project: 'Runtime'
  1. Runtime
  2. RUNTIME-3441

Inline CSS in mail fails with a empty CSS rule

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 4.8.13, 4.9.0
    • None
    • None
    • None

      When a newsletter template contains a empty CSS rule in <style> section like:

      #newsletter-sidebar1 .encart{
      }
      

      the following css rules are ignored because the selector and properties are inverted.

      This piece of code in SendMailHelper does not support empty rule:

      StringTokenizer st = new StringTokenizer(styleRules, "{}"); 
                  while (st.countTokens() > 1) 
                  { 
                      String selectors = st.nextToken();
                      String properties = st.nextToken();
      
                      String[] selector = selectors.split(",");
                      for (String s : selector)
                      {
                          if (StringUtils.isNotBlank(s))
                          {
                              rules.add(new CssRule(s.trim(), properties, rules.size()));
                          }
                      }
                  } 
      

      With a empty rule, the "properties" value is the next CSS rule instead of empty.

          [RUNTIME-3441] Inline CSS in mail fails with a empty CSS rule

          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.13 [ 19621 ]
          Fix Version/s Original: 4.8.12 [ 19602 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.12 [ 19602 ]
          Fix Version/s Original: 4.8.11 [ 19581 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.11 [ 19581 ]
          Fix Version/s Original: 4.8.10 [ 19481 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.10 [ 19481 ]
          Fix Version/s Original: 4.8.9 [ 19435 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.9 [ 19435 ]
          Fix Version/s Original: 4.8.8 [ 19424 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.8 [ 19424 ]
          Fix Version/s Original: 4.8.7 [ 19401 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.7 [ 19401 ]
          Fix Version/s Original: 4.8.6 [ 19380 ]
          Cédric Damioli made changes -
          Fix Version/s New: 4.8.6 [ 19380 ]
          Fix Version/s Original: 4.8.5 [ 19285 ]
          Laurence Aumeunier made changes -
          Fix Version/s New: 4.8.5 [ 19285 ]
          Fix Version/s Original: 4.8.4 [ 19181 ]
          Cédric Damioli made changes -
          Fix Version/s New: 4.7.17 [ 19197 ]
          Fix Version/s Original: 4.7.16 [ 19082 ]

            Unassigned Unassigned
            laurence Laurence Aumeunier
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: