• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • 3.9
    • None
    • None
    • None

      The purpose is to test one param or a group (asynchronously)
      The diff with validator, is that we do not want to check that the parameter respect a regexp, but that the parameter value is correct (e.g. the directory does exist, or the sql parameters are ok)

          [RUNTIME-718] Add a parameter checker

          By the way of inserting an icon and text in a button is to use "icon" and "text" : not "html" with your own hack (that is not correctly located)

          Raphaël Franchet added a comment - By the way of inserting an icon and text in a button is to use "icon" and "text" : not "html" with your own hack (that is not correctly located)

          Fixed:

          • Most checkers were hard-coding depending parameters id !
          • The url to warning icon was defined absolutely in the CSS (should be relative to webapp)

          For your problems of CSS, you did this the wrong way : there a simple way to do this "data-errorqtip" and "data-warnqtip" (for this last, a initWarnQtip is required on Labelable)

          Raphaël Franchet added a comment - Fixed: Most checkers were hard-coding depending parameters id ! The url to warning icon was defined absolutely in the CSS (should be relative to webapp) For your problems of CSS, you did this the wrong way : there a simple way to do this "data-errorqtip" and "data-warnqtip" (for this last, a initWarnQtip is required on Labelable)

          • Still some css to complete... : see the _generateStatusTip method

          Quentin Glinel-Mortreuil (Inactive) added a comment - Still some css to complete... : see the _generateStatusTip method

          moreover the send mail test should be removed for the moment

          Raphaël Franchet added a comment - moreover the send mail test should be removed for the moment

          Before applying this patch, do update.

          First of all there is still two bugs:

          • if a field that is part of a group swith is in error ; and then the group switch is unactivated ; the category stay red
          • when starting the config with empty mandatory fields ; they are not in error : normal ; when saving : this failed and the fields go in error : normal ; BUT the category does not go in error : BUG

          Now, let's be honnest, this is ugly and not usable : we will so do the following changes, that are :

          • when a test do fail, the parameters should go in warning mode (becarefull, that when the test become normal again, the parameters should go normal again only if they are not in warning due to another test!)
          • the layout of test i completely modified : there are now buttons in the form itself (one per test): the label is the one of the test, an small-icon may be required (conf of test should have 3 size of icons like any other conf in ametys) - and the test color will be reflected in the button
          • the labels have to be rewriten : let's talk about "verification" more then "test"
          • please clean useless images, css rules and js code.

          Raphaël Franchet added a comment - Before applying this patch, do update. First of all there is still two bugs: if a field that is part of a group swith is in error ; and then the group switch is unactivated ; the category stay red when starting the config with empty mandatory fields ; they are not in error : normal ; when saving : this failed and the fields go in error : normal ; BUT the category does not go in error : BUG Now, let's be honnest, this is ugly and not usable : we will so do the following changes, that are : when a test do fail, the parameters should go in warning mode (becarefull, that when the test become normal again, the parameters should go normal again only if they are not in warning due to another test!) the layout of test i completely modified : there are now buttons in the form itself (one per test): the label is the one of the test, an small-icon may be required (conf of test should have 3 size of icons like any other conf in ametys) - and the test color will be reflected in the button the labels have to be rewriten : let's talk about "verification" more then "test" please clean useless images, css rules and js code.

          Tests depending on invalid fields are now systematically disabled, unless the field is invisible.

          Quentin Glinel-Mortreuil (Inactive) added a comment - Tests depending on invalid fields are now systematically disabled, unless the field is invisible.

          A test depending on a non valid field should be disabled.
          (take care of not disabling an invalid but invisible field - invisibility due to group swith)

          e.g. remove the "sender adress" that is a mandatory field, should disable the send mail test

          Raphaël Franchet added a comment - A test depending on a non valid field should be disabled. (take care of not disabling an invalid but invisible field - invisibility due to group swith) e.g. remove the "sender adress" that is a mandatory field, should disable the send mail test

          Sorry for this overlooking. This is fixed in this version of the patch ( v9 ).

          Quentin Glinel-Mortreuil (Inactive) added a comment - Sorry for this overlooking. This is fixed in this version of the patch ( v9 ).

          I've warned you about a possible pb with this last point but you failed on it.
          if a fieldvaliditychange or a testvaliditychange just call ONE function with no parameter that will analyse ALL.

          In your case, in the last section I have 2 fields, I make both invalid and the one valid again : the general marker disappeared

          Raphaël Franchet added a comment - I've warned you about a possible pb with this last point but you failed on it. if a fieldvaliditychange or a testvaliditychange just call ONE function with no parameter that will analyse ALL. In your case, in the last section I have 2 fields, I make both invalid and the one valid again : the general marker disappeared

          • in addition to the parameter checkers, the validity/invalidity of a field is now reflected in the navigation panel

          Quentin Glinel-Mortreuil (Inactive) added a comment - - edited in addition to the parameter checkers, the validity/invalidity of a field is now reflected in the navigation panel

            quentin Quentin Glinel-Mortreuil (Inactive)
            raphael Raphaël Franchet
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: