Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-39

BitSet cache in AclCacheManager not used in practice

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 4.2.0
    • 4.2.0
    • None
    • 4.2 M9

      Few issues here :

      1. in AclCacheManager#_computeBitSetAndPutInCache, we do values.put(__CACHE_BISET_KEY, null); after writeLock.tryLock(), and if a second user asked its acl, it removes all BitSet entries before putting its own, that is to say not more than one BitSet is present in the cache.
      2. but this was hidden by filterCache and queryResultCache and in practice, the BitSet cache was never used => we should find a way to not use them when there is an AclQuery

            cedric Cédric Damioli
            sprieul Simon Prieul (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: