-
Bug
-
Resolution: Fixed
-
Major
-
2.9.0
-
None
The FilteredContentsInputData executes a JCR request to retrieve the contents having the tags corresponding to a filter.
This filter can also have a limit.
Let's say the limit is 1.
The InputData performs the request and finds the corresponding content.
After this, there is another filter, by label, in order to keep only the published contents.
If the content returned by the request is not published, it will be discarded and the InputData will not return any results.
But there may be other contents matching all the conditions in the repository that weren't returned by the query because of the limit.
[CMS-531] Tags - problem with the results of a filter when a max-results is fixed
Nicolas Gavalda (Inactive)
added a comment - Reworked the filters : the filtering on the content 'FR' label (when generating) is now done content by content, whereas it was done on the entire collection after limitation (same problem than filtering on specific conditions).
Applied the modification on the page filter too.
Nicolas Gavalda (Inactive)
added a comment - Reworked the filters : the filtering on the content 'FR' label (when generating) is now done content by content, whereas it was done on the entire collection after limitation (same problem than filtering on specific conditions).
Applied the modification on the page filter too. Nicolas Gavalda (Inactive)
added a comment - Resolution proposition :
There is a new method filterBySpecificConditions(Content) which tests a content for inclusion in the filter results.
This is the method to be overridden with project-specific logic. The old method filterBySpecificConditions(Collection<Content>) just tests the contents one by one with the new method.
The contents are limited after filtering, so sorting and limiting are not a problem anymore.
Nicolas Gavalda (Inactive)
added a comment - Resolution proposition :
There is a new method filterBySpecificConditions(Content) which tests a content for inclusion in the filter results.
This is the method to be overridden with project-specific logic. The old method filterBySpecificConditions(Collection<Content>) just tests the contents one by one with the new method.
The contents are limited after filtering, so sorting and limiting are not a problem anymore. 
Laurence Aumeunier
added a comment - Another case with problems:
I have a filter on content tagged NEWS and the max-result is set to 10.
The FilteredContentsInputData is extends in the project to filter also by date of validation. But this filter comes after the limitation of 10 results
By consequence, I do not obtain the 10 news with valid dates but a ramdom number between 0 and 10.
The only solution is to not set the max limit, retrieve all the news with valid dates and limit the displayed news in the template.xsl => not efficient
Laurence Aumeunier
added a comment - Another case with problems:
I have a filter on content tagged NEWS and the max-result is set to 10.
The FilteredContentsInputData is extends in the project to filter also by date of validation. But this filter comes after the limitation of 10 results
By consequence, I do not obtain the 10 news with valid dates but a ramdom number between 0 and 10.
The only solution is to not set the max limit, retrieve all the news with valid dates and limit the displayed news in the template.xsl => not efficient 
Julien Cimetiere (Inactive)
added a comment - Another solution would be to change the api to execute filter on only one content at a time.
All comments are also valid for the FilteredPageInputData.
Julien Cimetiere (Inactive)
added a comment - Another solution would be to change the api to execute filter on only one content at a time.
All comments are also valid for the FilteredPageInputData. Julien Cimetiere (Inactive)
added a comment - Here a possible solution :
Limitation is done after all filter, so there is no more limitation in JCR query.
This can have impact on performance.
Some types of query may not be affected, like sorted query.
Julien Cimetiere (Inactive)
added a comment - Here a possible solution :
Limitation is done after all filter, so there is no more limitation in JCR query.
This can have impact on performance.
Some types of query may not be affected, like sorted query. 
in hazard we trust